feat: ✨ improve icon review workflow #2689
Conversation
It should now be 100% correct in finding changed files ↪ This commit was largely generated by AI (Copilot with OpenAI model o1).
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Okinea Dev <81070564+okineadev@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
okineadev
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
I just tested it on my fork and it's still not working 🙁 It's still using the SVG from the main branch and not from the fork. I've mentioned this before, but will post it here again, would you please follow the next steps to test this workflow on your end?
- Fork the repo vscode-material-icon-theme
- Copy and paste the changes from this PR to the main branch of the fork
- Create a new branch in the fork (with the changed workflow on main)
- Change some icons
- Commit and push changes
- Create a new PR of this branch in the fork which targets to main in the fork
- Let the workflows run
It's some manual work which can't be done by AI, but it's costing me some time to do it on every review. Please do this on your end to verify your changes, before asking me again for another review.
PKief
force-pushed
the
main
branch
2 times, most recently
from
7918c28 to
7cb05b2
Compare
|
I've converted this PR to draft state, as it's not ready yet. Feel free to update it once you have time to work on it and to test it. Thank you. |
|
To improve the quality and to reduce the maintenance effort regular refactoring of the project is inevitable. As much as we appreciate your work and contribution in this pull request, we realised that it was created a while ago and some merge conflicts occurred. We have decided to close all PRs that no longer correspond to the current code base. This gives us the opportunity to provide a better overview of the remaining open PRs. We would like to offer you to update your changes to the main branch and reopen the PR if the contribution is still relevant for you. Please contact us, we will be happy to help you resolve any conflicts. Thank you for your attention and good collaboration. |
Description
Contribution Guidelines